On Fri, May 05, 2017 at 09:23:02AM +0200, walter harms wrote: > > sem is a global and it looks like it's intended to be held after > > device_open() returns and only released in device_close(), so this looks > > wrong. > > > > the patch relates to the error path, do you expect a close() after the open() > failed ? >
You can't close if open fails. Please don't ask rhetorical questions. Just state everything in short sentences using simple words. regards, dan carpenter
