On Fri, Jun 30, 2017 at 7:28 PM, Anshuman Khandual <khand...@linux.vnet.ibm.com> wrote: > On 06/30/2017 12:22 PM, Oliver O'Halloran wrote: >> Export it so it can be referenced inside a module. >> >> Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> >> --- >> arch/powerpc/mm/hugetlbpage.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c >> index ceeab69cf7fc..96293560f294 100644 >> --- a/arch/powerpc/mm/hugetlbpage.c >> +++ b/arch/powerpc/mm/hugetlbpage.c >> @@ -34,6 +34,7 @@ >> #define PAGE_SHIFT_16G 34 >> >> unsigned int HPAGE_SHIFT; >> +EXPORT_SYMBOL(HPAGE_SHIFT); > > Why would you need this in a driver ? This represents the > default HugeTLB page size.
Libnvdimm uses HPAGE_SIZE for a few things that it probably shouldn't. I have sent a fix for libnvdimm, but that hasn't been merged yet and this was breaking mpe's -next builds in the mean time. I agree it's kind of bad, but we needed ZONE_DEVICE support to be in 4.13. Oliver