> On Fri, 25 Jan 2008 16:06:27 +0100 Geert Uytterhoeven <[EMAIL PROTECTED]> > wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > ps3fb: inline the X_OFF(), Y_OFF(), WIDTH(), HEIGHT(), and VP_OFF() macros, > as they're used in one place only >
I think the term "open-code" would be more suitable here. "inlining" means "make it an inline function". I'll update the changelog. > -#define X_OFF(i) (ps3fb_res[i].xoff) /* left/right margin (pixel) */ > -#define Y_OFF(i) (ps3fb_res[i].yoff) /* top/bottom margin (pixel) */ > -#define WIDTH(i) (ps3fb_res[i].xres) /* width of FB */ > -#define HEIGHT(i) (ps3fb_res[i].yres) /* height of FB */ > #define BPP 4 /* number of bytes per pixel */ > > -/* Start of the virtual frame buffer (relative to fullscreen ) */ > -#define VP_OFF(i) ((WIDTH(i) * Y_OFF(i) + X_OFF(i)) * BPP) > - > > static int ps3fb_mode; > module_param(ps3fb_mode, int, 0); > @@ -611,7 +604,10 @@ static int ps3fb_set_par(struct fb_info > > par->width = info->var.xres; > par->height = info->var.yres; > - offset = VP_OFF(i); > + > + /* Start of the virtual frame buffer (relative to fullscreen) */ > + offset = ps3fb_res[i].yoff * ddr_line_length + ps3fb_res[i].xoff * BPP; > + _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
