On 11/16/2017 11:06 AM, Nathan Fontenot wrote:
> On 11/15/2017 12:09 PM, Michael Bringmann wrote:
>> Firmware Features: Define new bit flag representing the presence of
>> new device tree property "ibm,drc-info". The flag is used to tell
>> the front end processor whether the Linux kernel supports the new
>> property, and by the front end processor to tell the Linux kernel
>> that the new property is present in the device tree.
>
> This patch seems to be adding a bit for the drc-info feature so that
> we can use the firmware_has_feature() interface to determine if the
> device tree has the new ibm,drc-info properties.
>
> I'm not sure what front-end processor you're referring to? Is this
> in reference to the architecture vector that is exchanged with firmware?
I was trying to be generic instead of writing pHyp, BMC, or other.
We can change the comment if it is misleading.
>
> -Nathan
>
>>
>> Signed-off-by: Michael Bringmann <m...@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/include/asm/firmware.h | 3 ++-
>> arch/powerpc/include/asm/prom.h | 1 +
>> arch/powerpc/platforms/pseries/firmware.c | 1 +
>> 3 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/firmware.h
>> b/arch/powerpc/include/asm/firmware.h
>> index 8645897..329d537 100644
>> --- a/arch/powerpc/include/asm/firmware.h
>> +++ b/arch/powerpc/include/asm/firmware.h
>> @@ -51,6 +51,7 @@
>> #define FW_FEATURE_BEST_ENERGY ASM_CONST(0x0000000080000000)
>> #define FW_FEATURE_TYPE1_AFFINITY ASM_CONST(0x0000000100000000)
>> #define FW_FEATURE_PRRN ASM_CONST(0x0000000200000000)
>> +#define FW_FEATURE_DRC_INFO ASM_CONST(0x0000000400000000)
>>
>> #ifndef __ASSEMBLY__
>>
>> @@ -67,7 +68,7 @@ enum {
>> FW_FEATURE_CMO | FW_FEATURE_VPHN | FW_FEATURE_XCMO |
>> FW_FEATURE_SET_MODE | FW_FEATURE_BEST_ENERGY |
>> FW_FEATURE_TYPE1_AFFINITY | FW_FEATURE_PRRN |
>> - FW_FEATURE_HPT_RESIZE,
>> + FW_FEATURE_HPT_RESIZE | FW_FEATURE_DRC_INFO,
>> FW_FEATURE_PSERIES_ALWAYS = 0,
>> FW_FEATURE_POWERNV_POSSIBLE = FW_FEATURE_OPAL,
>> FW_FEATURE_POWERNV_ALWAYS = 0,
>> diff --git a/arch/powerpc/include/asm/prom.h
>> b/arch/powerpc/include/asm/prom.h
>> index 825bd59..3243455 100644
>> --- a/arch/powerpc/include/asm/prom.h
>> +++ b/arch/powerpc/include/asm/prom.h
>> @@ -175,6 +175,7 @@ struct of_drconf_cell {
>> #define OV5_HASH_GTSE 0x1940 /* Guest Translation Shoot Down
>> Avail */
>> /* Radix Table Extensions */
>> #define OV5_RADIX_GTSE 0x1A40 /* Guest Translation Shoot Down
>> Avail */
>> +#define OV5_DRC_INFO 0x1640 /* Redef Prop Structures:
>> drc-info */
>>
>> /* Option Vector 6: IBM PAPR hints */
>> #define OV6_LINUX 0x02 /* Linux is our OS */
>> diff --git a/arch/powerpc/platforms/pseries/firmware.c
>> b/arch/powerpc/platforms/pseries/firmware.c
>> index 63cc82a..757d757 100644
>> --- a/arch/powerpc/platforms/pseries/firmware.c
>> +++ b/arch/powerpc/platforms/pseries/firmware.c
>> @@ -114,6 +114,7 @@ struct vec5_fw_feature {
>> vec5_fw_features_table[] = {
>> {FW_FEATURE_TYPE1_AFFINITY, OV5_TYPE1_AFFINITY},
>> {FW_FEATURE_PRRN, OV5_PRRN},
>> + {FW_FEATURE_DRC_INFO, OV5_DRC_INFO},
>> };
>>
>> static void __init fw_vec5_feature_init(const char *vec5, unsigned long len)
>>
>
>
--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
m...@linux.vnet.ibm.com
