On Tue, 2008-02-05 at 09:50 -0500, Paul Gortmaker wrote: > In message: [PATCH] Fix legacy serial search for opb bus ports > on 05/02/2008 Michael Ellerman wrote: > > > The patch to legacy_serial.c (1a7507c7da2df6856e085e0fbb0c9ea8c12ac4e, > > Reduce code duplication in legacy_serial, add UART parent types) changed > > the semantics for opb ports from type = "opb" || compatible = "ibm,opb" > > to type = "opb" && compatible = "ibm,opb". > > Ah. I'd originally coded it as an || -- but then Arnd suggested I > condense it further by using of_match_node() -- which was a good idea, > but that is where it accidentally changed to && without me catching it. > Thanks for finding this, and sorry for the debug adventure (I know > vanishing uarts isn't fun).
Yeah it's easy to confuse, I had to look at of_match_node() fairly closely before I was convinced it was equivalent to &&. The bisect was fairly painless actually, so no dramas. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
