Le 17/01/2018 à 06:23, Aneesh Kumar K.V a écrit :
Christophe LEROY <christophe.le...@c-s.fr> writes:
How should I split in separate patches ? Something like ?
1/ Slice support for PPC32 > 2/ Activate slice for 8xx
Yes something like that. Will you be able to avoid that
if (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now
i don't have definite suggestion on what we could do though.
Could use #ifdefs instead, but in my mind it would be even more ugly.
I would have liked just doing nothing, but the issue is that at the
moment bitmap_xxx() functions are not prepared to handle bitmaps of size
zero. Should we try to change that ? Any chance to succeed ?
How much code duplication it is to do slice_32.c?
Most functions use both .low_slices and .high_slices, so if your thought
is to copy slice.c to slice_32.c and then remove all code handling
.high_slices, we will at least duplicate 50% of the code
In v2 that I have just submitted, I have embedded this ugly test in
macros called slice_bitmap_xxx() which handles the 0 nbits case. Tell me
if it looks better that way.
Christophe
Michael,
What do you suggest here?
-aneesh