On 02/21/2018 05:05 AM, Michael Ellerman wrote: > We had a mid-air collision between two new firmware features, DRMEM_V2 > and DRC_INFO, and they ended up with the same value. > > No one's actually reported any problems, presumably because the new > firmware that supports both properties is not widely available, and > the two properties tend to be enabled together. > > Still if we ever had one enabled but not the other, the bugs that > could result are many and varied. So fix it. > > Fixes: 3f38000eda48 ("powerpc/firmware: Add definitions for new drc-info > firmware feature") > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > ---
Good catch. Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > arch/powerpc/include/asm/firmware.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/firmware.h > b/arch/powerpc/include/asm/firmware.h > index 511acfd7ab0d..535add3f7791 100644 > --- a/arch/powerpc/include/asm/firmware.h > +++ b/arch/powerpc/include/asm/firmware.h > @@ -52,7 +52,7 @@ > #define FW_FEATURE_TYPE1_AFFINITY ASM_CONST(0x0000000100000000) > #define FW_FEATURE_PRRN ASM_CONST(0x0000000200000000) > #define FW_FEATURE_DRMEM_V2 ASM_CONST(0x0000000400000000) > -#define FW_FEATURE_DRC_INFO ASM_CONST(0x0000000400000000) > +#define FW_FEATURE_DRC_INFO ASM_CONST(0x0000000800000000) > > #ifndef __ASSEMBLY__ >