On Tue, Apr 3, 2018 at 7:24 AM, Oliver O'Halloran <ooh...@gmail.com> wrote: > This patch adds peliminary device-tree bindings for persistent memory > regions. The driver registers a libnvdimm bus for each pmem-region > node and each address range under the node is converted to a region > within that bus. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > --- > v2: Made each bus have a separate node rather having a shared bus. > Renamed to of_pmem rather than of_nvdimm. > Changed log level of happy-path messages to debug. > --- [..] > +static struct platform_driver of_nd_region_driver = { > + .probe = of_nd_region_probe, > + .remove = of_nd_region_remove, > + .driver = { > + .name = "of_pmem", > + .owner = THIS_MODULE, > + .of_match_table = of_nd_region_match, > + }, > +};
This and the other patches look good to me. Just a nit on the naming... since you name the regions pmem-regions in the device-tree description shouldn't this be the "of_pmem_region" or "of_pmem_range" driver? Otherwise, it is confusing to me that anything named *nd_region would be creating an nvdimm_bus. In general An nd_region is always a child of a bus. That said, with an ack/reviewed-by on the device-tree bindings I can take these through the nvdimm tree. I'll reply to patch 4 with that request for ack.