On 05/22/2018 09:55 PM, Jakub Kicinski wrote:
> On Tue, 22 May 2018 22:46:13 +0530, Sandipan Das wrote:
>> + if (info.nr_jited_func_lens && info.jited_func_lens) {
>> + struct kernel_sym *sym = NULL;
>> + unsigned char *img = buf;
>> + __u64 *ksyms = NULL;
>> + __u32 *lens;
>> + __u32 i;
>> +
>> + if (info.nr_jited_ksyms) {
>> + kernel_syms_load(&dd);
>> + ksyms = (__u64 *) info.jited_ksyms;
>> + }
>> +
>> + lens = (__u32 *) info.jited_func_lens;
>> + for (i = 0; i < info.nr_jited_func_lens; i++) {
>> + if (ksyms) {
>> + sym = kernel_syms_search(&dd, ksyms[i]);
>> + if (sym)
>> + printf("%s:\n", sym->name);
>> + else
>> + printf("%016llx:\n", ksyms[i]);
>> + }
>> +
>> + disasm_print_insn(img, lens[i], opcodes, name);
>> + img += lens[i];
>> + printf("\n");
>> + }
>> + } else {
>
> The output doesn't seem to be JSON-compatible :( We try to make sure
> all bpftool command can produce valid JSON when run with -j (or -p)
> switch.
>
> Would it be possible to make each function a separate JSON object with
> "name" and "insn" array? Would that work?
Sandipan, could you take a look at this? Given there's json output today we
should definitely try not to break it; presumably this would be one final
respin of your series with this fixed.
Thanks,
Daniel
