----- On Jun 5, 2018, at 1:21 AM, Michael Ellerman [email protected] wrote:
> Mathieu Desnoyers <[email protected]> writes: >> From: Boqun Feng <[email protected]> >> >> Syscalls are not allowed inside restartable sequences, so add a call to >> rseq_syscall() at the very beginning of system call exiting path for >> CONFIG_DEBUG_RSEQ=y kernel. This could help us to detect whether there >> is a syscall issued inside restartable sequences. >> >> [ Tested on 64-bit powerpc kernel by Mathieu Desnoyers. Still needs to >> be tested on 32-bit powerpc kernel. ] >> >> Signed-off-by: Boqun Feng <[email protected]> >> Signed-off-by: Mathieu Desnoyers <[email protected]> >> CC: Benjamin Herrenschmidt <[email protected]> >> CC: Paul Mackerras <[email protected]> >> CC: Michael Ellerman <[email protected]> >> CC: Peter Zijlstra <[email protected]> >> CC: "Paul E. McKenney" <[email protected]> >> CC: [email protected] >> --- >> arch/powerpc/kernel/entry_32.S | 7 +++++++ >> arch/powerpc/kernel/entry_64.S | 8 ++++++++ >> 2 files changed, 15 insertions(+) > > I don't _love_ the #ifdefs in here, but they look correct and there's > not really a better option until we rewrite the syscall handler in C. > > The rseq selftests passed for me with this applied and enabled. So if > you like here's some tags: > > Tested-by: Michael Ellerman <[email protected]> > Acked-by: Michael Ellerman <[email protected]> > Adding you ack to the series. Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
