Michal Suchánek <msucha...@suse.de> writes: > On Tue, 12 Jun 2018 02:59:11 +0000 > Bharat Bhushan <bharat.bhus...@nxp.com> wrote: > >> Hi Diana, >> >> > -----Original Message----- >> > From: Diana Craciun [mailto:diana.crac...@nxp.com] >> > Sent: Monday, June 11, 2018 6:23 PM >> > To: linuxppc-dev@lists.ozlabs.org >> > Cc: m...@ellerman.id.au; o...@buserror.net; Leo Li >> > <leoyang...@nxp.com>; Bharat Bhushan <bharat.bhus...@nxp.com>; >> > Diana Madalina Craciun <diana.crac...@nxp.com> >> > Subject: [PATCH v2 3/3] powerpc/fsl: Implement >> > cpu_show_spectre_v1/v2 for NXP PowerPC Book3E >> >> Please add some description > > To me the subject is self-explanatory. It implements a kernel interface > that was already described elsewhere. > > What are you missing here?
It should at least explain why it's reimplementing a function that already exists for powerpc. ie. Why can't the existing version be used? cheers