Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb....@gmail.com>
---
 drivers/tty/serial/kgdb_nmi.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
index 4029272..ed8f806 100644
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -234,7 +234,6 @@ static const struct tty_port_operations 
kgdb_nmi_tty_port_ops = {
 static int kgdb_nmi_tty_install(struct tty_driver *drv, struct tty_struct *tty)
 {
        struct kgdb_nmi_tty_priv *priv;
-       int ret;
 
        priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
@@ -245,17 +244,9 @@ static int kgdb_nmi_tty_install(struct tty_driver *drv, 
struct tty_struct *tty)
        tty_port_init(&priv->port);
        priv->port.ops = &kgdb_nmi_tty_port_ops;
        tty->driver_data = priv;
+       tty_port_install(&priv->port, drv, tty);
 
-       ret = tty_port_install(&priv->port, drv, tty);
-       if (ret) {
-               pr_err("%s: can't install tty port: %d\n", __func__, ret);
-               goto err;
-       }
        return 0;
-err:
-       tty_port_destroy(&priv->port);
-       kfree(priv);
-       return ret;
 }
 
 static void kgdb_nmi_tty_cleanup(struct tty_struct *tty)
-- 
2.7.4

Reply via email to