On Fri, Sep 21, 2018 at 02:20:15PM +0800, kbuild test robot wrote: > Hi Gautham, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.19-rc4 next-20180919] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/powerpc-Detection-and-scheduler-optimization-for-POWER9-bigcore/20180921-085812 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: powerpc-mpc837x_mds_defconfig (attached as .config) > compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=powerpc > > All errors (new ones prefixed by >>): > > arch/powerpc/kernel/sysfs.c: In function 'smallcore_thread_siblings_show': > >> arch/powerpc/kernel/sysfs.c:724:45: error: implicit declaration of > >> function 'cpu_smallcore_mask'; did you mean 'cpu_all_mask'? > >> [-Werror=implicit-function-declaration] > return cpumap_print_to_pagebuf(false, buf, cpu_smallcore_mask(cpu)); > ^~~~~~~~~~~~~~~~~~
No, the smallcore_thread_siblings_show, and the other functions should only be compiled for CONFIG_SMP. Will add this. Thanks bot! > cpu_all_mask > >> arch/powerpc/kernel/sysfs.c:724:45: error: passing argument 3 of > >> 'cpumap_print_to_pagebuf' makes pointer from integer without a cast > >> [-Werror=int-conversion] > In file included from include/linux/rcupdate.h:44:0, > from include/linux/radix-tree.h:28, > from include/linux/idr.h:15, > from include/linux/kernfs.h:14, > from include/linux/sysfs.h:16, > from include/linux/kobject.h:20, > from include/linux/device.h:16, > from arch/powerpc/kernel/sysfs.c:1: > include/linux/cpumask.h:892:1: note: expected 'const struct cpumask *' but > argument is of type 'int' > cpumap_print_to_pagebuf(bool list, char *buf, const struct cpumask *mask) > ^~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/kernel/sysfs.c: In function > 'smallcore_thread_siblings_list_show': > arch/powerpc/kernel/sysfs.c:734:44: error: passing argument 3 of > 'cpumap_print_to_pagebuf' makes pointer from integer without a cast > [-Werror=int-conversion] > return cpumap_print_to_pagebuf(true, buf, cpu_smallcore_mask(cpu)); > ^~~~~~~~~~~~~~~~~~ > In file included from include/linux/rcupdate.h:44:0, > from include/linux/radix-tree.h:28, > from include/linux/idr.h:15, > from include/linux/kernfs.h:14, > from include/linux/sysfs.h:16, > from include/linux/kobject.h:20, > from include/linux/device.h:16, > from arch/powerpc/kernel/sysfs.c:1: > include/linux/cpumask.h:892:1: note: expected 'const struct cpumask *' but > argument is of type 'int' > cpumap_print_to_pagebuf(bool list, char *buf, const struct cpumask *mask) > ^~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > vim +724 arch/powerpc/kernel/sysfs.c > > 717 > 718 static ssize_t smallcore_thread_siblings_show(struct device > *dev, > 719 struct device_attribute > *attr, > 720 char *buf) > 721 { > 722 int cpu = dev->id; > 723 > > 724 return cpumap_print_to_pagebuf(false, buf, > cpu_smallcore_mask(cpu)); > 725 } > 726 static DEVICE_ATTR_RO(smallcore_thread_siblings); > 727 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation