Hi York, Just a few things from a first pass.
On Wed, 12 Mar 2008 16:43:42 -0500 York Sun <[EMAIL PROTECTED]> wrote:
>
> +++ b/drivers/video/fsl-diu-fb.c
>
> +#include <asm/of_platform.h>
Please include <linux/of_platform.h> instead.
> +/* Align to 64-bit(8-byte), 32-byte, etc. */
> +static int allocate_buf(struct diu_addr *buf, u32 size, u32 bytes_align)
> +{
>
> + buf->vaddr = dma_alloc_coherent(0, ssize,
> + (dma_addr_t *) &(buf->paddr),
This cast is unnecessary as buf->paddr is a dma_addr_t ...
> +++ b/drivers/video/fsl-diu-fb.h
>
> +static struct fb_videomode __devinitdata fsl_diu_default_mode = {
> +static struct fb_videomode __devinitdata fsl_diu_mode_db[] = {
Why are these in the .h file? They should be in the .c file.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpK1onq6ve7k.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
