Hi,

Le 28/01/2019 à 10:07, Mathias Thore a écrit :
After a timeout event caused by for example a broadcast storm, when
the MAC and PHY are reset, the BQL TX queue needs to be reset as
well. Otherwise, the device will exhibit severe performance issues
even after the storm has ended.

What are the symptomns ?

Is this reset needed on any network driver in that case, or is it something particular for the ucc_geth ? For instance, the freescale fs_enet doesn't have that reset. Should it have it too ?

Christophe


Co-authored-by: David Gounaris <david.gouna...@infinera.com>
Signed-off-by: Mathias Thore <mathias.th...@infinera.com>
---
  drivers/net/ethernet/freescale/ucc_geth.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/freescale/ucc_geth.c 
b/drivers/net/ethernet/freescale/ucc_geth.c
index c3d539e209ed..eb3e65e8868f 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -1879,6 +1879,8 @@ static void ucc_geth_free_tx(struct ucc_geth_private 
*ugeth)
        u16 i, j;
        u8 __iomem *bd;
+ netdev_reset_queue(ugeth->ndev);
+
        ug_info = ugeth->ug_info;
        uf_info = &ug_info->uf_info;

Reply via email to