On Friday 28 March 2008 14:58, Laurent Pinchart wrote: > On Thursday 27 March 2008 16:39, Scott Wood wrote: > > On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote: > > > On Wednesday 26 March 2008 17:59, Scott Wood wrote: > > > > This breaks the bootwrapper console. > > > > > > And of course I forgot about that :-) > > > > > > The boot wrapper code doesn't have any dpram allocator. Any objection against > > > using a chunk of dpram at a fixed location ? What about at the beginning of > > > the dpram ? The DTS muram node would then exclude a chunk of dpram at offset > > > 0x0000 instead of 0x1100. > > > > I'm not entirely comfortable with using a chunk outside of what's in the > > muram node, and assuming that it's for the SMC pram -- what if there's > > microcode or something there? > > > > Since udbg is only for debugging, and is marked as potentially dangerous, > > how about just using the end of muram (as described in the device tree)? > > If the muram is fully allocated, it won't happen until after the real > > serial console is initialized. > > Very good idea. I'll prepare a new patch.
arch/powerpc/boot/cpm-serial.c stores the udbg buffer descriptors at the beginning of the muram. Should I move them at the end as well ? -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpWJ7Sujdp9M.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev