Hi Christoph, > -----Original Message----- > From: Christoph Hellwig <h...@infradead.org> > Sent: Friday, May 31, 2019 7:32 PM > > On Thu, May 30, 2019 at 05:19:50PM +0300, laurentiu.tu...@nxp.com wrote: > > +static phys_addr_t dpaa_iova_to_phys(const struct dpaa_priv *priv, > > + dma_addr_t addr) > > +{ > > + return priv->domain ? iommu_iova_to_phys(priv->domain, addr) : addr; > > +} > > Again, a driver using the iommu API must not call iommu_* APIs. > > This chane is not acceptable.
Unfortunately due to our hardware particularities we do not have alternatives. This is also the case for our next generation of ethernet drivers [1]. I'll let my colleagues that work on the ethernet drivers to comment more on this. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c#n37 --- Best Regards, Laurentiu