Hari Bathini <hbath...@linux.ibm.com> writes: > On 03/09/19 4:40 PM, Michael Ellerman wrote: >> Hari Bathini <hbath...@linux.ibm.com> writes: >>> diff --git a/arch/powerpc/include/asm/opal.h >>> b/arch/powerpc/include/asm/opal.h >>> index 57bd029..878110a 100644 >>> --- a/arch/powerpc/include/asm/opal.h >>> +++ b/arch/powerpc/include/asm/opal.h >>> @@ -39,6 +39,12 @@ int64_t opal_npu_spa_clear_cache(uint64_t phb_id, >>> uint32_t bdfn, >>> uint64_t PE_handle); >>> int64_t opal_npu_tl_set(uint64_t phb_id, uint32_t bdfn, long cap, >>> uint64_t rate_phys, uint32_t size); >>> + >>> +int64_t opal_mpipl_update(enum opal_mpipl_ops op, u64 src, >>> + u64 dest, u64 size); >>> +int64_t opal_mpipl_register_tag(enum opal_mpipl_tags tag, uint64_t addr); >>> +int64_t opal_mpipl_query_tag(enum opal_mpipl_tags tag, uint64_t *addr); >>> + >> >> Please consistently use kernel types for new prototypes in here. > > uint64_t instead of 'enum's?
The enums are fine, I mean u64 instead of uint64_t, s64 instead of int64_t etc. cheers
