Hari Bathini <hbath...@linux.ibm.com> writes: > diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c > b/arch/powerpc/platforms/powernv/opal-fadump.c > index e466f7e..91fb909 100644 > --- a/arch/powerpc/platforms/powernv/opal-fadump.c > +++ b/arch/powerpc/platforms/powernv/opal-fadump.c > @@ -52,6 +68,8 @@ static ulong opal_fadump_init_mem_struct(struct fw_dump > *fadump_conf) > opal_fdm->fadumphdr_addr = (opal_fdm->rgn[0].dest + > fadump_conf->boot_memory_size); > > + opal_fadump_update_config(fadump_conf, opal_fdm); > + > return addr; > } > > @@ -97,12 +115,69 @@ static int opal_fadump_setup_metadata(struct fw_dump > *fadump_conf) > > static int opal_fadump_register(struct fw_dump *fadump_conf) > { > - return -EIO; > + int i, err = -EIO; > + s64 rc;
Some compiler versions are warning about this being used uninitialised: arch/powerpc/platforms/powernv/opal-fadump.c:316:3: error: 'rc' may be used uninitialized in this function [-Werror=uninitialized] http://kisskb.ellerman.id.au/kisskb/buildresult/13943984/ Which does seem like a legitimate warning. cheers