Richard Henderson <richard.hender...@linaro.org> writes: > We cannot use the pointer output without validating the > success of the random read.
You _can_, but you must not. </pedant> > Signed-off-by: Richard Henderson <r...@twiddle.net> > --- > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > --- > arch/powerpc/include/asm/archrandom.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Michael Ellerman <m...@ellerman.id.au> cheers > diff --git a/arch/powerpc/include/asm/archrandom.h > b/arch/powerpc/include/asm/archrandom.h > index f8a887c8b7f8..ee214b153a71 100644 > --- a/arch/powerpc/include/asm/archrandom.h > +++ b/arch/powerpc/include/asm/archrandom.h > @@ -6,17 +6,17 @@ > > #include <asm/machdep.h> > > -static inline bool arch_get_random_long(unsigned long *v) > +static inline bool __must_check arch_get_random_long(unsigned long *v) > { > return false; > } > > -static inline bool arch_get_random_int(unsigned int *v) > +static inline bool __must_check arch_get_random_int(unsigned int *v) > { > return false; > } > > -static inline bool arch_get_random_seed_long(unsigned long *v) > +static inline bool __must_check arch_get_random_seed_long(unsigned long *v) > { > if (ppc_md.get_random_seed) > return ppc_md.get_random_seed(v); > @@ -24,7 +24,7 @@ static inline bool arch_get_random_seed_long(unsigned long > *v) > return false; > } > > -static inline bool arch_get_random_seed_int(unsigned int *v) > +static inline bool __must_check arch_get_random_seed_int(unsigned int *v) > { > unsigned long val; > bool rc; > -- > 2.17.1