On Apr 21, 2008, at 5:12 PM, Benjamin Herrenschmidt wrote:

On Mon, 2008-04-21 at 17:04 -0500, Kumar Gala wrote:
On Apr 21, 2008, at 4:22 PM, Benjamin Herrenschmidt wrote:


_GLOBAL(__setup_cpu_603)
-       b       setup_common_caches
+       mflr    r4
+BEGIN_FTR_SECTION
+       bl      __init_fpu_registers
+END_FTR_SECTION_IFCLR(CPU_FTR_FPU_UNAVAILABLE)
+       bl      __init_fpu_registers
+       bl      setup_common_caches
+       mtlr    r4
+       blr
_GLOBAL(__setup_cpu_604)
        mflr    r4
        bl      setup_common_cache

Has the feature fixup been perform yet when __setup_* is called ?

Yes.  We call do_feature_fixups() in early_init and call
call_setup_cpu() after than on 6xx (in head_32.S).

Hrm. I think that may be the other way around on 64 bits... damn, I need
to consolidate these.

I'd rather have the init code explicitely test for the features.

Ok, but we'd also need to fix setup_750_7400_hid0 and setup_745x_specifics to test.

There's a bit more cleanup that needs to be done here. I'm not going to worry about it for this patch since it covers handling a chip errata and isn't any more "broken" than other bits of code in this file.

- k _______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to