On 03/03/2020 11:18 PM, Vlastimil Babka wrote:
> On 3/2/20 7:47 AM, Anshuman Khandual wrote:
>> There are many places where all basic VMA access flags (read, write, exec)
>> are initialized or checked against as a group. One such example is during
>> page fault. Existing vma_is_accessible() wrapper already creates the notion
>> of VMA accessibility as a group access permissions. Hence lets just create
>> VM_ACCESS_FLAGS (VM_READ|VM_WRITE|VM_EXEC) which will not only reduce code
>> duplication but also extend the VMA accessibility concept in general.
>>
>> Cc: Russell King <li...@armlinux.org.uk>
>> CC: Catalin Marinas <catalin.mari...@arm.com>
>> CC: Mark Salter <msal...@redhat.com>
>> Cc: Nick Hu <nic...@andestech.com>
>> CC: Ley Foon Tan <ley.foon....@intel.com>
>> Cc: Michael Ellerman <m...@ellerman.id.au>
>> Cc: Heiko Carstens <heiko.carst...@de.ibm.com>
>> Cc: Yoshinori Sato <ys...@users.sourceforge.jp>
>> Cc: Guan Xuetao <g...@pku.edu.cn>
>> Cc: Dave Hansen <dave.han...@linux.intel.com>
>> Cc: Thomas Gleixner <t...@linutronix.de>
>> Cc: Rob Springer <rsprin...@google.com>
>> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>> Cc: Andrew Morton <a...@linux-foundation.org>
>> Cc: linux-arm-ker...@lists.infradead.org
>> Cc: linux-c6x-...@linux-c6x.org
>> Cc: nios2-...@lists.rocketboards.org
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: linux-s...@vger.kernel.org
>> Cc: linux...@vger.kernel.org
>> Cc: de...@driverdev.osuosl.org
>> Cc: linux...@kvack.org
>> Cc: linux-ker...@vger.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khand...@arm.com>
>
> Dunno. Such mask seems ok for testing flags, but it's a bit awkward when
> initializing flags, where it covers just one of many combinations that seem
> used. But no strong opinions, patch looks correct.
Fair enough. The fact that it covers only one of the many init combinations
used at various places, is indeed a good point. The page fault handlers does
start with VMA flags mask as VM_ACCESS_FLAGS, hence will keep them and drop
other init cases here.
