Hi Sascha, One small comment.
On Thu, 24 Apr 2008 17:36:59 +0200 Sascha Hauer <[EMAIL PROTECTED]> wrote:
>
> +#include <asm/of_platform.h>
Never include <asm/of_platform.h>, use <linux/of_platform.h>
> +static struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
const, please.
OK, I lied about only one comment :-)
> +static struct of_device_id mpc52xx_simple_gpiochip_match[] = {
const, again.
> +static struct of_device_id mpc52xx_gpt_gpiochip_match[] = {
Another one.
Also, I don't think you need to include <asm/prom.h>
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp33FHfMuPwH.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
