Re: [PATCH 13/15] powerpc/powernv/sriov: Move M64 BAR allocation into a helper

[Alexey Kardashevskiy]

On 10/07/2020 15:23, Oliver O'Halloran wrote:
> I want to refactor the loop this code is currently inside of. Hoist it on
> out.
> 
> Signed-off-by: Oliver O'Halloran <ooh...@gmail.com>



Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru>


> ---
>  arch/powerpc/platforms/powernv/pci-sriov.c | 31 ++++++++++++++--------
>  1 file changed, 20 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c 
> b/arch/powerpc/platforms/powernv/pci-sriov.c
> index d5699cd2ab7a..2f967aa4fbf5 100644
> --- a/arch/powerpc/platforms/powernv/pci-sriov.c
> +++ b/arch/powerpc/platforms/powernv/pci-sriov.c
> @@ -416,6 +416,23 @@ static int64_t pnv_ioda_map_m64_single(struct pnv_phb 
> *phb,
>       return rc;
>  }
>  
> +static int pnv_pci_alloc_m64_bar(struct pnv_phb *phb, struct pnv_iov_data 
> *iov)
> +{
> +     int win;
> +
> +     do {
> +             win = find_next_zero_bit(&phb->ioda.m64_bar_alloc,
> +                             phb->ioda.m64_bar_idx + 1, 0);
> +
> +             if (win >= phb->ioda.m64_bar_idx + 1)
> +                     return -1;
> +     } while (test_and_set_bit(win, &phb->ioda.m64_bar_alloc));
> +
> +     set_bit(win, iov->used_m64_bar_mask);
> +
> +     return win;
> +}
> +
>  static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs)
>  {
>       struct pnv_iov_data   *iov;
> @@ -443,17 +460,9 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, 
> u16 num_vfs)
>                       continue;
>  
>               for (j = 0; j < m64_bars; j++) {
> -
> -                     /* allocate a window ID for this BAR */
> -                     do {
> -                             win = 
> find_next_zero_bit(&phb->ioda.m64_bar_alloc,
> -                                             phb->ioda.m64_bar_idx + 1, 0);
> -
> -                             if (win >= phb->ioda.m64_bar_idx + 1)
> -                                     goto m64_failed;
> -                     } while (test_and_set_bit(win, 
> &phb->ioda.m64_bar_alloc));
> -                     set_bit(win, iov->used_m64_bar_mask);
> -
> +                     win = pnv_pci_alloc_m64_bar(phb, iov);
> +                     if (win < 0)
> +                             goto m64_failed;
>  
>                       if (iov->m64_single_mode) {
>                               int pe_num = iov->vf_pe_arr[j].pe_number;
> 

-- 
Alexey