On 15/07/2020 12:53, Oliver O'Halloran wrote: > On Wed, Jul 15, 2020 at 12:29 PM Alexey Kardashevskiy <a...@ozlabs.ru> wrote: >> >> >> >> On 10/07/2020 15:23, Oliver O'Halloran wrote: >>> Rework the PE allocation logic to allow allocating blocks of PEs rather >>> than individually. We'll use this to allocate contigious blocks of PEs for >>> the SR-IOVs. >> >> The patch does not do just this, it also adds missing mutexes (which is >> good) but still misses them in pnv_pci_sriov_disable() and >> pnv_pci_ioda_pe_dump(). > > The current implementation doesn't need the mutex because alloc, > reserve and free all use atomic bit ops. Ah, ok. > The mutex has been there > forever with nothing actually using it, but with the change we need to > prevent modifications to the bitmap while alloc() is scanning it. I > probably should have mentioned that in the commit message. but bitmap_clear() (from pnv_pci_sriov_disable()) is not atomic. It probably does not matter as the next patch gets rid of it anyway. -- Alexey
- [PATCH 07/15] powerpc/powernv/sriov: Rename truncate_... Oliver O'Halloran
- Re: [PATCH 07/15] powerpc/powernv/sriov: Rename ... Alexey Kardashevskiy
- [PATCH 08/15] powerpc/powernv/sriov: Simplify used wi... Oliver O'Halloran
- Re: [PATCH 08/15] powerpc/powernv/sriov: Simplif... Alexey Kardashevskiy
- Re: [PATCH 08/15] powerpc/powernv/sriov: Sim... Oliver O'Halloran
- [PATCH 09/15] powerpc/powernv/sriov: Factor out M64 B... Oliver O'Halloran
- Re: [PATCH 09/15] powerpc/powernv/sriov: Factor ... Alexey Kardashevskiy
- [PATCH 10/15] powerpc/powernv/pci: Refactor pnv_ioda_... Oliver O'Halloran
- Re: [PATCH 10/15] powerpc/powernv/pci: Refactor ... Alexey Kardashevskiy
- Re: [PATCH 10/15] powerpc/powernv/pci: Refac... Oliver O'Halloran
- Re: [PATCH 10/15] powerpc/powernv/pci: R... Alexey Kardashevskiy
- [PATCH 11/15] powerpc/powernv/sriov: Drop iov->pe_... Oliver O'Halloran
- Re: [PATCH 11/15] powerpc/powernv/sriov: Drop io... Alexey Kardashevskiy
- [PATCH 12/15] powerpc/powernv/sriov: De-indent setup ... Oliver O'Halloran
- Re: [PATCH 12/15] powerpc/powernv/sriov: De-inde... Alexey Kardashevskiy
- Re: [PATCH 12/15] powerpc/powernv/sriov: De-... Oliver O'Halloran
- Re: [PATCH 12/15] powerpc/powernv/sriov:... Alexey Kardashevskiy
- Re: [PATCH 12/15] powerpc/powernv/sr... Oliver O'Halloran
- Re: [PATCH 12/15] powerpc/power... Alexey Kardashevskiy
- [PATCH 13/15] powerpc/powernv/sriov: Move M64 BAR all... Oliver O'Halloran
- Re: [PATCH 13/15] powerpc/powernv/sriov: Move M6... Alexey Kardashevskiy