Hi Nicholas, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on arm64/for-next/core v5.11-rc5 next-20210125] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210126-143141 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/e43d3c665212ea34b790ab8d150bbde9d42e35b8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/huge-vmalloc-mappings/20210126-143141 git checkout e43d3c665212ea34b790ab8d150bbde9d42e35b8 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): mm/debug_vm_pgtable.c: In function 'pmd_huge_tests': mm/debug_vm_pgtable.c:221:7: error: implicit declaration of function 'arch_ioremap_pmd_supported'; did you mean 'arch_vmap_pmd_supported'? [-Werror=implicit-function-declaration] 221 | if (!arch_ioremap_pmd_supported()) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | arch_vmap_pmd_supported mm/debug_vm_pgtable.c: In function 'pud_huge_tests': >> mm/debug_vm_pgtable.c:343:7: error: implicit declaration of function >> 'arch_ioremap_pud_supported'; did you mean 'arch_vmap_pud_supported'? >> [-Werror=implicit-function-declaration] 343 | if (!arch_ioremap_pud_supported()) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | arch_vmap_pud_supported cc1: some warnings being treated as errors vim +343 mm/debug_vm_pgtable.c a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 337 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 338 #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 339 static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 340 { a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 341 pud_t pud; a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 342 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 @343 if (!arch_ioremap_pud_supported()) a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 344 return; 6315df41afccf1 Anshuman Khandual 2020-08-06 345 6315df41afccf1 Anshuman Khandual 2020-08-06 346 pr_debug("Validating PUD huge\n"); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 347 /* a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 348 * X86 defined pud_set_huge() verifies that the given a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 349 * PUD is not a populated non-leaf entry. a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 350 */ a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 351 WRITE_ONCE(*pudp, __pud(0)); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 352 WARN_ON(!pud_set_huge(pudp, __pfn_to_phys(pfn), prot)); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 353 WARN_ON(!pud_clear_huge(pudp)); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 354 pud = READ_ONCE(*pudp); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 355 WARN_ON(!pud_none(pud)); a5c3b9ffb0f404 Anshuman Khandual 2020-08-06 356 } 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 357 #else /* !CONFIG_HAVE_ARCH_HUGE_VMAP */ 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 358 static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgprot_t prot) { } 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 359 #endif /* !CONFIG_HAVE_ARCH_HUGE_VMAP */ 85a144632dcc71 Aneesh Kumar K.V 2020-10-15 360 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
