On Wed, Jun 11, 2008 at 3:41 AM, David Jander <[EMAIL PROTECTED]> wrote: > On Tuesday 10 June 2008 22:37:18 you wrote: >> Thanks for the patch, comments below. >> > --- /dev/null >> > +++ b/arch/powerpc/platforms/512x/prtlvt.c >> >> Looks like you've just duplicated mpc5121_ads.c. You should just add >> your boards name to the mpc5121_ads_probe function. Bonus points if >> you rename the .c file to something more generic. You only need a new >> board file if your board needs something special. > > Well, it looks like mpc5121_ads.c is pretty generic. The MPC5121 is almost > a "motherboard-in-a-chip" type of SoC, so there isn't much board-specific > stuff anywhere. IO-control register setup should be done in the boot-loader. > What should we do about this then? Rename the whole mpc5121_ads stuff to > something more generic? What about calling it "mpc5121_generic.c"?
mpc5121_generic.c works for me. > Btw, you posted this to linucppc-dev mailing list, but I think that was a > mistake, since this is clearly an embedded processor, so I removed the CC. Nope, not a mistake. Discussions on embedded stuff is welcome on the linuxppc-dev mailing list. There has been some talk of removing the linuxppc-embedded list entirely. I've added the list back to the to: list. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev