Thanks, looks reasonable.
Reviewed-by: Alistair Popple <alist...@popple.id.au>
On Saturday, 18 September 2021 7:22:32 PM AEST Christophe Leroy wrote:
> arch/powerpc/platforms/44x/ppc476.c:236:17: warning: cast removes
> address space '__iomem' of expression
> arch/powerpc/platforms/44x/ppc476.c:241:34: warning: incorrect type in
> argument 1 (different address spaces)
> arch/powerpc/platforms/44x/ppc476.c:241:34: expected void const
> volatile [noderef] __iomem *addr
> arch/powerpc/platforms/44x/ppc476.c:241:34: got unsigned char
> [usertype] *
> arch/powerpc/platforms/44x/ppc476.c:243:17: warning: incorrect type in
> argument 1 (different address spaces)
> arch/powerpc/platforms/44x/ppc476.c:243:17: expected void volatile
> [noderef] __iomem *addr
> arch/powerpc/platforms/44x/ppc476.c:243:17: got unsigned char
> [usertype] *[assigned] fpga
>
> Mark 'fpga' pointer as __iomem.
>
> Reported-by: kernel test robot <l...@intel.com>
> Fixes: ab9a4183fddf ("powerpc: Update currituck pci/usb fixup for new board
> revision")
> Cc: Alistair Popple <alist...@popple.id.au>
> Signed-off-by: Christophe Leroy <christophe.le...@csgroup.eu>
> ---
> arch/powerpc/platforms/44x/ppc476.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/44x/ppc476.c
> b/arch/powerpc/platforms/44x/ppc476.c
> index 07f7e3ce67b5..fb7db5cedd4e 100644
> --- a/arch/powerpc/platforms/44x/ppc476.c
> +++ b/arch/powerpc/platforms/44x/ppc476.c
> @@ -219,7 +219,7 @@ static int board_rev = -1;
> static int __init ppc47x_get_board_rev(void)
> {
> int reg;
> - u8 *fpga;
> + u8 __iomem *fpga;
> struct device_node *np = NULL;
>
> if (of_machine_is_compatible("ibm,currituck")) {
> @@ -233,7 +233,7 @@ static int __init ppc47x_get_board_rev(void)
> if (!np)
> goto fail;
>
> - fpga = (u8 *) of_iomap(np, 0);
> + fpga = of_iomap(np, 0);
> of_node_put(np);
> if (!fpga)
> goto fail;
>
