Sam Ravnborg wrote:
But I was misguided by:
+config FS_ENET_MPC5121_FEC
+ select FS_ENET
This is not good.
Why not, if we get rid of the prompt on FS_ENET?
In general when you select a symbol that has dependencies you are almost
always on the wrong track.
The dependencies on FS_ENET could continue to be valuable as
documentation and verification of the conditions under which the driver
will build, but the more specific options should make sure that they
never select it when the dependencies aren't met.
Use a dependency here with a sane default - then people can
set it to 'n' if they really do not want this driver.
Spreading selects too much is just causing you pain in the long run.
I'm not sure I understand what you're looking for, but I don't see
anything wrong with something like this (apart from missing help text):
config FS_ENET
bool
select MII
select PHYLIB
config FS_ENET_HAS_SCC
bool "Freescale CPM SCC Ethernet"
depends on CPM1 || CPM2
select FS_ENET
config FS_ENET_HAS_FCC
bool "Freescale CPM FCC Ethernet"
depends on CPM2
select FS_ENET
config FS_ENET_HAS_FEC
bool "Freescale Fast Ethernet Controller"
depends on CPM1 || PPC_MPC512x
select FS_ENET
config FS_ENET_MDIO_FEC
bool "Freescale FEC MDIO"
depends on FS_ENET_HAS_FEC
config FS_ENET_MDIO_BITBANG
bool "Freescale CPM Bitbanged MDIO"
depends on CPM2
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
