I agree, I'll separate the fec_t -> struct fec changes out. On Tue, Jun 17, 2008 at 11:20 PM, Grant Likely <[EMAIL PROTECTED]> wrote:
> On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <[EMAIL PROTECTED]> wrote: > > Fixed all errors and warnings that checkpatch.pl > > reports if this was a new submission. > > Also changed instances of fec_t to struct fec in > > mac-fec.c and mii-fec.c. > > Nit: checkpatch is not law; particularly in the case of whitespace > change. Personally, I think cleaning up whitespace in this regard > causes more problems than it solves. Plus, it makes the important > change (fec_t -> struct fec) get lost in a see of unimportant ones > which makes for hard reviewing. > > But I must sleep now; I'll review your other patch tomorrow. > > Cheers, > g. > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev >
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
