Excerpts from Christophe Leroy's message of October 22, 2021 4:49 pm: > > > Le 22/10/2021 à 00:30, Nicholas Piggin a écrit : >> mmu_linear_psize is only set at boot once on 64e, is not necessarily >> the correct size of the linear map pages, and is never used anywhere. >> Remove it. > > mmu_linear_psize is defined as a macro in: > > arch/powerpc/include/asm/book3s/32/mmu-hash.h, line 152 (as a macro) > arch/powerpc/include/asm/nohash/32/mmu-40x.h, line 66 (as a macro) > arch/powerpc/include/asm/nohash/32/mmu-44x.h, line 150 (as a macro) > arch/powerpc/include/asm/nohash/32/mmu-8xx.h, line 173 (as a macro) > > Is that needed at all or should is be cleaned, if nothing else than 64s > uses it ? > > Otherwise, why not do the same with 64e and define it as a macro ? Maybe > that would help minimising the amount of ifdefs.
I prefer to remove it entirely, to avoid situations like 64e where it was being used without understanding what the value really was. 32e can come in a later cleanup to avoid making this series any bigger. Thanks, Nick
