On Mon, Dec 06, 2021 at 11:27:46PM +0100, Thomas Gleixner wrote: > No need to walk the descriptors and check for each one whether the entries > pointer function argument is NULL. Do it once. > > Signed-off-by: Thomas Gleixner <[email protected]> > Tested-by: Juergen Gross <[email protected]> > Reviewed-by: Jason Gunthorpe <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]> > --- > drivers/pci/msi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -642,8 +642,8 @@ static void msix_update_entries(struct p > { > struct msi_desc *entry; > > - for_each_pci_msi_entry(entry, dev) { > - if (entries) { > + if (entries) { > + for_each_pci_msi_entry(entry, dev) { > entries->vector = entry->irq; > entries++; > } >
