On 9/13/22 1:45 PM, Christophe Leroy wrote:
Le 13/09/2022 à 09:40, Disha Goel a écrit :
There were commits which did code refactoring and converting some of kvm
assembly routines to C. When doing it, many of the asm-offset macro
definitions were missed to remove. Patchset here removes those.
Patch1 removes usage of KVM_TLB_SETS macro from the asm-offset
Patch2 removes KVM_RADIX macro from the asm-offset.c
Patch3 removes a set of unused kvm vcpu and hstate macros from the
asm-offset.c
Patch4 removes unused HSTATE/host_mmcr references for MMCR3/SIER2/SIER3
I think you can squash all changes to asm-offsets.c into a single patch.
The Fixes: tags are unrelevant, you are not fixing a real bug, it's just
a cleanup.
Then have a second patch that reduces the size of host_mmcr[] in
kvmppc_host_state struct.
Hi Christophe,
Thanks for reviewing the patchset. I will send v2 patchset with
mentioned changes.
Thanks
Disha
Thanks
Christophe
Link to the script used to get unused macro:
https://github.com/maddy-kerneldev/scripts/blob/master/check_asm-offset.sh
Link to linux-ci job result:
https://github.com/disgoel/linux-ci/actions
Disha Goel (3):
powerpc/asm-offset: Remove unused KVM_TLB_SETS macros
powerpc/asm-offset: Remove unused KVM_RADIX macros
powerpc/kvm: Remove unused macros from asm-offset
Kajol Jain (1):
powerpc/kvm: Remove unused references for MMCR3/SIER2/SIER3 registers
arch/powerpc/include/asm/kvm_book3s_asm.h | 2 +-
arch/powerpc/kernel/asm-offsets.c | 25 -----------------------
2 files changed, 1 insertion(+), 26 deletions(-)
