On Monday 14 July 2008 04:02:41 am Paul Mackerras wrote: > > Below attached patch defines this macro for powerpc arch. Please let > > me know your comments on this. > > > > +#define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.regs) > > The cast is unnecessary since tsk->thread.regs is already a struct > pt_regs *.
True. > Also note that tsk->thread.regs will be NULL for a kernel > thread. Yes, users of task_pt_regs will verify for NULL. Updated patch attached below. Signed-off-by: Srinivasa DS <[EMAIL PROTECTED]> --- include/asm-powerpc/processor.h | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.26-rc9/include/asm-powerpc/processor.h =================================================================== --- linux-2.6.26-rc9.orig/include/asm-powerpc/processor.h +++ linux-2.6.26-rc9/include/asm-powerpc/processor.h @@ -214,6 +214,8 @@ struct thread_struct { #define thread_saved_pc(tsk) \ ((tsk)->thread.regs? (tsk)->thread.regs->nip: 0) +#define task_pt_regs(tsk) (tsk)->thread.regs + unsigned long get_wchan(struct task_struct *p); #define KSTK_EIP(tsk) ((tsk)->thread.regs? (tsk)->thread.regs->nip: 0) _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev