On Mon, 2008-07-14 at 14:01 +0530, Srinivasa D S wrote: > On Monday 14 July 2008 04:02:41 am Paul Mackerras wrote: > > > Below attached patch defines this macro for powerpc arch. Please let > > > me know your comments on this. > > > > > > +#define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.regs) > > > > The cast is unnecessary since tsk->thread.regs is already a struct > > pt_regs *. > > True. > > > Also note that tsk->thread.regs will be NULL for a kernel > > thread. > > Yes, users of task_pt_regs will verify for NULL. Updated patch attached > below. > > Signed-off-by: Srinivasa DS <[EMAIL PROTECTED]>
Can you send a cleanup patch against powerpc.git instead ? Thanks ! Ben _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
