On Tue, Jul 08, 2008 at 05:36:31PM -0500, Nathan Lynch wrote:
> I think this code that counts SMT threads and compares against NR_CPUS
> is an artifact of pre-powerpc-merge ppc64. We care about starting
> only primary threads in the OF client code.
<snip>
> - prom_printf("%x : starting cpu hw idx %x... ", cpuid,
> reg);
> + prom_printf("starting cpu hw idx %x... ", reg);
If we remove this, where else can we see the mapping of hardware IDs
to logical cpu IDs? This is useful on POWER4 (at least where they can be
different).
<snip>
> - if (cpuid > NR_CPUS)
> - prom_printf("WARNING: maximum CPUs (" __stringify(NR_CPUS)
> - ") exceeded: ignoring extras\n");
> -
I think this printf() is valuable, if your boot a 128 thread machine on
a kernel with NR_CPUS=64, this is the only messaage you get to indicate
that you're wasting 64 threads, and how to resolve it.
Yours Tony
linux.conf.au http://www.marchsouth.org/
Jan 19 - 24 2009 The Australian Linux Technical Conference!
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
