Tony Breeds wrote:
> On Tue, Jul 08, 2008 at 05:36:31PM -0500, Nathan Lynch wrote:
>
> > - prom_printf("%x : starting cpu hw idx %x... ", cpuid,
> > reg);
> > + prom_printf("starting cpu hw idx %x... ", reg);
>
> If we remove this, where else can we see the mapping of hardware IDs
> to logical cpu IDs? This is useful on POWER4 (at least where they can be
> different).
sysfs. (e.g. /sys/devices/system/cpu/cpu0/physical_id)
> > - if (cpuid > NR_CPUS)
> > - prom_printf("WARNING: maximum CPUs (" __stringify(NR_CPUS)
> > - ") exceeded: ignoring extras\n");
> > -
>
> I think this printf() is valuable, if your boot a 128 thread machine on
> a kernel with NR_CPUS=64, this is the only messaage you get to indicate
> that you're wasting 64 threads, and how to resolve it.
The proper place for such a message is in the kernel's smp bringup
code later on, and/or the code that initializes the various cpu maps.
The prom_init code should not really be concerned with the kernel's
NR_CPUS configuration or mapping of logical to physical ids.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
