On Mon Mar 20, 2023 at 7:47 PM AEST, Cédric Le Goater wrote:
> Hello Nick,
>
> On 3/20/23 08:03, Nicholas Piggin wrote:
> > This is a basic first pass at powernv support using OPAL (skiboot)
> > firmware.
> >
> > The ACCEL is a bit clunky, now defaulting to tcg for powernv machine.
> > It also does not yet run in the run_tests.sh batch process, more work
> > is needed to exclude certain tests (e.g., rtas) and adjust parameters
> > (e.g., increase memory size) to allow powernv to work. For now it
> > can run single test cases.
>
> Why do you need to load OPAL ? for the shutdown ? because the UART ops
> could be done directly using MMIOs on the LPC IO space.
Don't really need it but I thought it would be easier to begin with, and
then I thought actually it's nice to have this kind of test harness for
skiboot as well. So I would hope to keep the skiboot bios option even if
a no-bios version was done.
[...]
> > void io_init(void)
> > {
> > - rtas_init();
> > + if (machine_is_powernv())
> > + opal_init();
> > + else
> > + rtas_init();
> > }
[...]
> > @@ -195,6 +197,8 @@ void setup(const void *fdt)
> > freemem += initrd_size;
> > }
> >
> > + opal_init();
> > +
>
> This opal_init() call seems redundant with io_init().
Oh you're right good catch, that might be an old piece before I cleaned
it up. I'll have to fix that and re-test it.
Thanks,
Nick
