On Thu, 2023-03-30 at 16:50 +1100, Benjamin Gray wrote: > * Include unistd.h for _exit() > * Include stdio.h for fprintf() > * Adds _MSG assertion variants to provide more context behind why a > failure occurred. > * Move ARRAY_SIZE macro to utils.h > > The _MSG variants and ARRAY_SIZE will be used by the following > DEXCR selftests. > > Signed-off-by: Benjamin Gray <bg...@linux.ibm.com> >
I'd prefer if your commit message led with adding FAIL_IF_MSG etc and then mentioned the other changes to support it. It's unintuitive to read as-is. Reviewed-by: Russell Currey <rus...@russell.cc>