On Thu, 15 Jun 2023 at 03:02, Nicholas Piggin <npig...@gmail.com> wrote: > > On Wed Jun 14, 2023 at 11:09 AM AEST, Joel Stanley wrote: > > On Thu, 8 Jun 2023 at 07:58, Nicholas Piggin <npig...@gmail.com> wrote: > > > > > > Posting again, a couple of patches were merged and accounted for review > > > comments from last time. > > > > I saw some failures in the spr tests running on a power9 powernv system: > > > > $ TESTNAME=sprs TIMEOUT=90s ACCEL= ./powerpc/run powerpc/sprs.elf -smp > > 1 |grep FAIL > > FAIL: WORT ( 895): 0x00000000c0deba80 <==> 0x0000000000000000 > > This is just TCG machine? I'm not sure why WORT fails, AFAIKS it's the > same on POWER8 and doesn't do anything just a simple register. I think > on real hardware WORT may not have any bits implemented on POWER9 > though.
Yeah, just the TCG machine. Now that you point it out all of the failures I reported are for ACCEL=<blank>, so they are running in tcg mode. run_migration timeout -k 1s --foreground 90s /usr/bin/qemu-system-ppc64 -nodefaults -machine pseries,accel=tcg -bios powerpc/boot_rom.bin -display none -serial stdio -kernel powerpc/sprs.elf -smp 1 -append -w # -initrd /tmp/tmp.61XhbvCGcb > > > $ MIGRATION=yes TESTNAME=sprs-migration TIMEOUT=90s ACCEL= > > ./powerpc/run powerpc/sprs.elf -smp 1 -append '-w' | grep FAIL > > FAIL: SRR0 ( 26): 0xcafefacec0debabc <==> 0x0000000000402244 > > FAIL: SRR1 ( 27): 0xc0000006409ebab6 <==> 0x8000000000001001 > > FAIL: CTRL ( 136): 0x00000000 <==> 0x00008001 > > FAIL: WORT ( 895): 0x00000000c0deba80 <==> 0x0000000000000000 > > FAIL: PIR (1023): 0x00000010 <==> 0x00000049 > > > > Linux 6.2.0-20-generic > > QEMU emulator version 7.2.0 (Debian 1:7.2+dfsg-5ubuntu2) > > > > On a power8 powernv: > > > > MIGRATION=yes TESTNAME=sprs-migration TIMEOUT=90s ACCEL= ./powerpc/run > > powerpc/sprs.elf -smp 1 -append '-w' |grep FAIL > > FAIL: SRR0 ( 26): 0xcafefacec0debabc <==> 0x0000000000402234 > > FAIL: SRR1 ( 27): 0xc0000006409ebab6 <==> 0x8000000000001000 > > FAIL: CTRL ( 136): 0x00000000 <==> 0x00008001 > > FAIL: PIR (1023): 0x00000060 <==> 0x00000030 > > Hmm, seems we take some interrupt over migration test that is not > accounted for (could check the address in SRR0 to see where it is). > Either need to prevent that interrupt or avoid failing on SRR0/1 on > this test. > > Interesting about CTRL, I wonder if that not migrating correctly. > PIR looks like a migration issue as well, it can't be changed so > destination CPU has got a different PIR. I would be inclined to > leave those as failing to remind us to look into them. > > I'll take a look at the others though. > > Thanks, > Nick
