> On 24-Jun-2023, at 5:10 AM, Namhyung Kim <namhy...@kernel.org> wrote:
>
> Hello,
>
> On Wed, Jun 21, 2023 at 1:30 AM Athira Rajeev
> <atraj...@linux.vnet.ibm.com> wrote:
>>
>> Patchset covers a set of fixes for coding/formatting issues observed while
>> running shellcheck tool on the perf shell scripts.
>>
>> This cleanup is a pre-requisite to include a build option for shellcheck
>> discussed here: https://www.spinics.net/lists/linux-perf-users/msg25553.html
>> First set of patches were posted here:
>> https://lore.kernel.org/linux-perf-users/53b7d823-1570-4289-a632-2205ee2b5...@linux.vnet.ibm.com/T/#t
>>
>> This patchset covers remaining set of shell scripts which needs
>> fix. Patch 1 is resubmission of patch 6 from the initial series.
>> Patch 15, 16 and 22 touches code from tools/perf/trace/beauty.
>> Other patches are fixes for scripts from tools/perf/tests.
>
> Thanks for this work. But it seems there are some issues
> even after applying this series.
>
> $ for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do
>> shellcheck $F; done | grep -c -e '(info)' -e '(warning)'
> 29
>
> $ for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do
>> shellcheck $F; done | grep ^In
> In tests/shell/pipe_test.sh line 10:
> In tests/shell/pipe_test.sh line 15:
> In tests/shell/pipe_test.sh line 20:
> In tests/shell/pipe_test.sh line 21:
> In tests/shell/pipe_test.sh line 26:
> In tests/shell/pipe_test.sh line 27:
> In tests/shell/pipe_test.sh line 33:
> In tests/shell/record+zstd_comp_decomp.sh line 16:
> In tests/shell/record+zstd_comp_decomp.sh line 22:
> In tests/shell/record+zstd_comp_decomp.sh line 27:
> In tests/shell/record+zstd_comp_decomp.sh line 28:
> In tests/shell/record+zstd_comp_decomp.sh line 29:
> In tests/shell/record+zstd_comp_decomp.sh line 30:
> In tests/shell/record+zstd_comp_decomp.sh line 36:
> In tests/shell/coresight/thread_loop_check_tid_2.sh line 8:
> In tests/shell/coresight/thread_loop_check_tid_2.sh line 11:
> In tests/shell/coresight/thread_loop_check_tid_2.sh line 14:
>
> Also unfortunately there's some update in the shell tests.
> Please rebase onto the perf-tools-next.
Hi Namhyung
Thanks for checking. Will send an updated version on top of perf-tools-next
Thanks
Athira
>
> Thanks,
> Namhyung
>
>
>>
>> Akanksha J N (1):
>> tools/perf/tests: Fix shellcheck warnings for
>> trace+probe_vfs_getname.sh
>>
>> Athira Rajeev (11):
>> tools/perf/tests: fix test_arm_spe_fork.sh signal case issues
>> tools/perf/tests: Fix unused variable references in
>> stat+csv_summary.sh testcase
>> tools/perf/tests: fix shellcheck warning for
>> test_perf_data_converter_json.sh testcase
>> tools/perf/tests: Fix shellcheck issue for stat_bpf_counters.sh
>> testcase
>> tools/perf/tests: Fix shellcheck issues in
>> tests/shell/stat+shadow_stat.sh tetscase
>> tools/perf/tests: Fix shellcheck warnings for
>> thread_loop_check_tid_10.sh
>> tools/perf/tests: Fix shellcheck warnings for unroll_loop_thread_10.sh
>> tools/perf/tests: Fix shellcheck warnings for lib/probe_vfs_getname.sh
>> tools/perf/tests: Fix the shellcheck wanrings in lib/waiting.sh
>> tools/perf/trace: Fix x86_arch_prctl.sh to address shellcheck warnings
>> tools/perf/arch/x86: Fix syscalltbl.sh to address shellcheck warnings
>>
>> Kajol Jain (10):
>> tools/perf/tests: Fix shellcheck warning for probe_vfs_getname.sh
>> testcase
>> tools/perf/tests: Fix shellcheck warning for record_offcpu.sh testcase
>> tools/perf/tests: Fix shellcheck issue for lock_contention.sh testcase
>> tools/perf/tests: Fix shellcheck issue for stat_bpf_counters_cgrp.sh
>> testcase
>> tools/perf/tests: Fix shellcheck warning for asm_pure_loop.sh shell
>> script
>> tools/perf/tests: Fix shellcheck warning for memcpy_thread_16k_10.sh
>> shell script
>> tools/perf/tests: Fix shellcheck warning for coresight.sh shell script
>> tools/perf/tests: Fix shellcheck warning for probe.sh shell script
>> tools/perf/trace: Fix shellcheck issue for arch_errno_names.sh script
>> tools/perf: Fix shellcheck issue for check-headers.sh script
>>
>> .../arch/x86/entry/syscalls/syscalltbl.sh | 2 +-
>> tools/perf/check-headers.sh | 6 ++--
>> .../tests/shell/coresight/asm_pure_loop.sh | 2 +-
>> .../shell/coresight/memcpy_thread_16k_10.sh | 2 +-
>> .../coresight/thread_loop_check_tid_10.sh | 2 +-
>> .../shell/coresight/unroll_loop_thread_10.sh | 2 +-
>> tools/perf/tests/shell/lib/coresight.sh | 3 +-
>> tools/perf/tests/shell/lib/probe.sh | 1 +
>> .../perf/tests/shell/lib/probe_vfs_getname.sh | 5 ++--
>> tools/perf/tests/shell/lib/waiting.sh | 1 +
>> tools/perf/tests/shell/lock_contention.sh | 12 ++++----
>> tools/perf/tests/shell/probe_vfs_getname.sh | 4 +--
>> tools/perf/tests/shell/record_offcpu.sh | 6 ++--
>> tools/perf/tests/shell/stat+csv_summary.sh | 4 +--
>> tools/perf/tests/shell/stat+shadow_stat.sh | 4 +--
>> tools/perf/tests/shell/stat_bpf_counters.sh | 4 +--
>> .../tests/shell/stat_bpf_counters_cgrp.sh | 28 ++++++++-----------
>> tools/perf/tests/shell/test_arm_spe_fork.sh | 2 +-
>> .../shell/test_perf_data_converter_json.sh | 2 +-
>> .../tests/shell/trace+probe_vfs_getname.sh | 6 ++--
>> tools/perf/trace/beauty/arch_errno_names.sh | 15 ++++------
>> tools/perf/trace/beauty/x86_arch_prctl.sh | 6 ++--
>> 22 files changed, 58 insertions(+), 61 deletions(-)
>>
>> --
>> 2.39.1