On Wed, Nov 08, 2023 at 01:58:30PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <a...@arndb.de> > > When -Wmissing-prototypes is enabled, the some asm-offsets.c files fail > to build, even when this warning is disabled in the Makefile for normal > files: > > arch/sparc/kernel/asm-offsets.c:22:5: error: no previous prototype for > 'sparc32_foo' [-Werror=missing-prototypes] > arch/sparc/kernel/asm-offsets.c:48:5: error: no previous prototype for 'foo' > [-Werror=missing-prototypes] > > Address this by making use of the same trick as x86, marking these > functions as 'static __used' to avoid the need for a prototype > by not drop them in dead-code elimination. > > Suggested-by: Masahiro Yamada <masahi...@kernel.org> > Link: > https://lore.kernel.org/lkml/cak7lnarfemfk0du4hed19ex_g6tuc5wg0zp+l1ayvdpof4y...@mail.gmail.com/ > Signed-off-by: Arnd Bergmann <a...@arndb.de> Looks good. I sometimes looks at sparc patches so I looked at this one. Reviewed-by: Sam Ravnborg <s...@ravnborg.org>
- [PATCH 03/22] [RESEND] kprobes: unify kprobes_exceptions... Arnd Bergmann
- [PATCH 04/22] [RESEND] time: make sysfs_get_uname() func... Arnd Bergmann
- Re: [PATCH 04/22] [RESEND] time: make sysfs_get_una... Uwe Kleine-König
- [PATCH 05/22] [RESEND] parport: gsc: mark init function ... Arnd Bergmann
- [PATCH 06/22] [RESEND] stackleak: add declarations for g... Arnd Bergmann
- [PATCH 07/22] [RESEND] sched: fair: move unused stub fun... Arnd Bergmann
- [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise... Arnd Bergmann
- [PATCH 09/22] [v2] arch: fix asm-offsets.c building with... Arnd Bergmann
- Re: [PATCH 09/22] [v2] arch: fix asm-offsets.c buil... Sam Ravnborg
- [PATCH 10/22] microblaze: include linux/cpu.h for trap_i... Arnd Bergmann
- Re: [PATCH 10/22] microblaze: include linux/cpu.h f... Arnd Bergmann
- [PATCH 11/22] x86: sta2x11: include header for sta2x11_g... Arnd Bergmann
- [PATCH 12/22] csky: fix arch_jump_label_transform_static... Arnd Bergmann
- [PATCH 13/22] arch: add do_page_fault prototypes Arnd Bergmann
- [PATCH 14/22] arch: add missing prepare_ftrace_return() ... Arnd Bergmann
- [PATCH 15/22] arch: vdso: consolidate gettime prototypes Arnd Bergmann
- Re: [PATCH 15/22] arch: vdso: consolidate gettime p... Christophe Leroy
- Re: [PATCH 15/22] arch: vdso: consolidate getti... Arnd Bergmann