Hi Niklas,
On 2/10/2024 6:56 AM, Niklas Cassel wrote:
The series is based on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=endpoint
Hello all,
This series cleans up the hardware description for PCI endpoint BARs.
The problems with the existing hardware description:
-The documentation is lackluster.
-Some of the names are confusingly similar, e.g. fixed_64bit and
fixed_size, even though these are for completely unrelated things.
-The way that the BARs are defined in the endpoint controller drivers
is messy, because the left hand side is not a BAR, so you can mark a
BAR as e.g. both fixed size and reserved.
This series tries to address all the problems above.
Personally, I think that the code is more readable, both the endpoint
controller drivers, but also pci-epc-core.c.
Thank you for cleaning this up!
FWIW:
Reviewed-by: Kishon Vijay Abraham I <kis...@kernel.org>
(Oh, and as you can probably guess, I will be sending out a patch series
that adds BAR_RESIZABLE to enum pci_epc_bar_type in the coming week(s).)
Kind regards,
Niklas
Niklas Cassel (2):
PCI: endpoint: Clean up hardware description for BARs
PCI: endpoint: Drop only_64bit on reserved BARs
drivers/pci/controller/dwc/pci-imx6.c | 3 +-
drivers/pci/controller/dwc/pci-keystone.c | 12 +++---
.../pci/controller/dwc/pci-layerscape-ep.c | 5 ++-
drivers/pci/controller/dwc/pcie-keembay.c | 8 +++-
drivers/pci/controller/dwc/pcie-rcar-gen4.c | 4 +-
drivers/pci/controller/dwc/pcie-tegra194.c | 10 +++--
drivers/pci/controller/dwc/pcie-uniphier-ep.c | 15 ++++++--
drivers/pci/controller/pcie-rcar-ep.c | 14 ++++---
drivers/pci/endpoint/functions/pci-epf-ntb.c | 4 +-
drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++--
drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +-
drivers/pci/endpoint/pci-epc-core.c | 25 +++++-------
drivers/pci/endpoint/pci-epf-core.c | 15 ++++----
include/linux/pci-epc.h | 38 ++++++++++++++++---
14 files changed, 105 insertions(+), 58 deletions(-)