Greetings,

This is tied to gcc version. Build failure is seen while using gcc-8.5.x

On 2/29/24 20:17, Jakub Kicinski wrote:
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
I do not see other solution than this, otherwise we have to add more
pollution to include/linux/netdevice.h
Right :(

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 
a9c973b92294bb110cf3cd336485972127b01b58..40797ea80bc6273cae6b7773d0a3e47459a72150
100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2469,7 +2469,7 @@ struct net_device {
         struct devlink_port     *devlink_port;

  #if IS_ENABLED(CONFIG_DPLL)
-       struct dpll_pin __rcu   *dpll_pin;
+       void __rcu *dpll_pin;
  #endif
If DPLL wants to hide its type definitions the helpers must live
in dpll? IOW move netdev_dpll_pin() to drivers/dpll/dpll_core.c

BTW Tasmiya, please do tell us what compiler you're using.

--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center

Reply via email to