On Thu, 7 Aug 2008, Paul Mackerras wrote:
>
> I think you want "return -ENOIOCTLCMD" rather than "return ret" since
> ret is uninitialized with your patch applied.
Actually, nobody has apparently ever even tried compiling that function
even before.
Yes, 'ret' became uninitialized, but since it was never declared, it
doesn't matter - it wouldn't compile anyway.
> I agree the call to n_tty_ioctl is bogus but I think we just want to
> return -ENOIOCTLCMD.
I made that change, and in the spirit of that file I also didn't even try
to compile it. So if the end result sexually assaults your pets, don't
blame me.
Linus
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
