Andrew - FYI there's nothing to worry about here, the type remains precisely the same, and I'll send a patch to fix this trivial issue so when later this type changes vmalloc will be uaffected.
On Tue, Jul 29, 2025 at 09:15:51AM +0900, Harry Yoo wrote: > [Adding Uladzislau to Cc] Ulad - could we PLEASE get rid of 'vm_flags' in vmalloc? It's the precise same name and (currently) type as vma->vm_flags and is already the source of confusion. > > Hi Lorenzo, just wanted to clarify one thing. > > You know, many people acked and reviewed it, which makes me wonder if > I'm misunderstanding something... but it wouldn't hurt to check, right? Thanks for report. Yes this is a mistake, the naming caught my mechanical changes, I tried to check everything but given scope of the change and unfortunate vmalloc naming I made a mistake. Net result currently is _absolutely no delta_ due to vm_flags_t == unsigned long. So there's nothing urgent here. But will send a patch to fix so it doesn't get caught in the 'part 2' changes I plan for this in 6.18. Fact others didn't notice underlines the fact this naming needs fixing in vmalloc. Thanks, Lorenzo
