On Wed, Oct 29, 2025 at 06:47:19AM +0100, Christian Zigotzky wrote: > > On 29 October 2025 at 00:33 am, Bjorn Helgaas <[email protected]> wrote: > > On Mon, Oct 27, 2025 at 06:12:24PM +0100, Christian Zigotzky wrote: > >> Hi All, > >> > >> I activated CONFIG_PCIEASPM and CONFIG_PCIEASPM_DEFAULT again for the RC3 > >> of > >> kernel 6.18. Unfortunately my AMD Radeon HD6870 doesn't work with the > >> latest > >> patches. > >> > >> But that doesn't matter because we disable the above kernel options by > >> default. We don't need power management for PCI Express because of boot > >> issues and performance issues. > > > > If you have a chance, could you try the patch below on top of > > v6.18-rc3 with CONFIG_PCIEASPM=y? > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index 214ed060ca1b..2b6d4e0958aa 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev > > *dev) > > * disable both L0s and L1 for now to be safe. > > */ > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, > > quirk_disable_aspm_l0s_l1); > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_FREESCALE, 0x0451, > > quirk_disable_aspm_l0s_l1); > > > > /* > > * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain > > Thanks for the patch. > > I will test it on my FSL Cyrus+ board over the weekend. > BTW, I also tested my PASemi Nemo board with the RC3 of kernel 6.18 > and with power management for PCI Express enabled. Unfortunately, > the installed AMD Radeon HD5870 does not work with power management > for PCI Express enabled either.
Oops, I made that fixup run too late. Instead of the patch above, can you test the one below? You'll likely see something like this, which is a little misleading because even though we claim "default L1" for 01:00.0 (or whatever your Radeon is), the fact that L0s and L1 are disabled at the other end of the link (00:00.0) should prevent us from actually enabling it: pci 0000:00:00.0: Disabling ASPM L0s/L1 pci 0000:01:00.0: ASPM: default states L1 diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 214ed060ca1b..27777ded9a2c 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev) * disable both L0s and L1 for now to be safe. */ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1); +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, 0x0451, quirk_disable_aspm_l0s_l1); /* * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
