On Thu, Oct 23, 2025 at 08:27:25PM +0200, Dragan Simic wrote: > On Thursday, October 23, 2025 20:06 CEST, Bjorn Helgaas <[email protected]> > wrote: > > From: Bjorn Helgaas <[email protected]> > > > > f3ac2ff14834 ("PCI/ASPM: Enable all ClockPM and ASPM states for devicetree > > platforms") enabled Clock Power Management and L1 PM Substates, but those > > features depend on CLKREQ# and possibly other device-specific > > configuration. We don't know whether CLKREQ# is supported, so we shouldn't > > blindly enable Clock PM and L1 PM Substates. > > > > Enable only ASPM L0s and L1, and only when both ends of the link advertise > > support for them. > > > > Fixes: f3ac2ff14834 ("PCI/ASPM: Enable all ClockPM and ASPM states for > > devicetree platforms") > > Reported-by: Christian Zigotzky <[email protected]> > > Link: > > https://lore.kernel.org/r/[email protected]/ > > Reported-by: FUKAUMI Naoki <[email protected]> > > Closes: > > https://lore.kernel.org/r/[email protected]/ > > Reported-by: Herve Codina <[email protected]> > > Link: https://lore.kernel.org/r/[email protected]/ > > Reported-by: Diederik de Haas <[email protected]> > > Link: https://lore.kernel.org/r/[email protected]/ > > Signed-off-by: Bjorn Helgaas <[email protected]> > > Tested-by: FUKAUMI Naoki <[email protected]> > > --- > > I intend this for v6.18-rc3. > > > > I think it will fix the issues reported by Diederik and FUKAUMI Naoki (both > > on Rockchip). I hope it will fix Christian's report on powerpc, but don't > > have confirmation. I think the performance regression Herve reported is > > related, but this patch doesn't seem to fix it. > > > > FUKAUMI Naoki's successful testing report: > > https://lore.kernel.org/r/[email protected]/ > > I'm more than happy with the way ASPM patches for DT platforms and > Rockchip SoCs in particular are unfolding! Admittedly, we've had > a rough start with the blanket enabling of ASPM, which followed the > theory, but the theory often differs from practice, so the combined > state of this and associated patches from Shawn should be fine. > > Thank you very much for all the effort that included quite a lot > of back and forth, and please feel free to include > > Acked-by: Dragan Simic <[email protected]>
Added your ack; thanks for all your help!
