Re: [PATCH v4 19/28] KVM: TDX: Derive error argument names from the local variable names

[Binbin Wu]

On 10/31/2025 4:09 AM, Sean Christopherson wrote:

When printing SEAMCALL errors, use the name of the variable holding an
error parameter instead of the register from whence it came, so that flows
which use descriptive variable names will similarly print descriptive
error messages.

Suggested-by: Rick Edgecombe <rick.p.edgeco...@intel.com>
Signed-off-by: Sean Christopherson <sea...@google.com>

Reviewed-by: Binbin Wu <binbin...@linux.intel.com>

---
  arch/x86/kvm/vmx/tdx.c | 13 +++++++------
  1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
index 5e6f2d8b6014..63d4609cc3bc 100644
--- a/arch/x86/kvm/vmx/tdx.c
+++ b/arch/x86/kvm/vmx/tdx.c
@@ -41,14 +41,15 @@
  #define TDX_BUG_ON(__err, __fn, __kvm)                                \
        __TDX_BUG_ON(__err, #__fn, __kvm, "%s", "")

-#define TDX_BUG_ON_1(__err, __fn, __rcx, __kvm) \

-       __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx", __rcx)
+#define TDX_BUG_ON_1(__err, __fn, a1, __kvm)                   \
+       __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx", a1)

-#define TDX_BUG_ON_2(__err, __fn, __rcx, __rdx, __kvm) \

-       __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx, rdx 0x%llx", __rcx, 
__rdx)
+#define TDX_BUG_ON_2(__err, __fn, a1, a2, __kvm)       \
+       __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx, " #a2 " 0x%llx", 
a1, a2)

-#define TDX_BUG_ON_3(__err, __fn, __rcx, __rdx, __r8, __kvm) \

-       __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx, rdx 0x%llx, r8 
0x%llx", __rcx, __rdx, __r8)
+#define TDX_BUG_ON_3(__err, __fn, a1, a2, a3, __kvm)   \
+       __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx, " #a2 ", 0x%llx, " #a3 
" 0x%llx", \
+                    a1, a2, a3)

bool enable_tdx __ro_after_init;