On Thu, Jan 15, 2026 at 10:20:07AM +0100, David Hildenbrand (Red Hat) wrote: > Adding "extern" to functions is frowned-upon. Let's just get rid of it > for all functions here.
Yes, this is nice thanks! > > Signed-off-by: David Hildenbrand (Red Hat) <[email protected]> LGTM so: Reviewed-by: Lorenzo Stoakes <[email protected]> > --- > include/linux/balloon_compaction.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/linux/balloon_compaction.h > b/include/linux/balloon_compaction.h > index eec8994056a44..7757e0e314fdb 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -59,14 +59,14 @@ struct balloon_dev_info { > bool adjust_managed_page_count; > }; > > -extern struct page *balloon_page_alloc(void); > -extern void balloon_page_enqueue(struct balloon_dev_info *b_dev_info, > - struct page *page); > -extern struct page *balloon_page_dequeue(struct balloon_dev_info > *b_dev_info); > -extern size_t balloon_page_list_enqueue(struct balloon_dev_info *b_dev_info, > - struct list_head *pages); > -extern size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, > - struct list_head *pages, size_t > n_req_pages); > +struct page *balloon_page_alloc(void); > +void balloon_page_enqueue(struct balloon_dev_info *b_dev_info, > + struct page *page); > +struct page *balloon_page_dequeue(struct balloon_dev_info *b_dev_info); > +size_t balloon_page_list_enqueue(struct balloon_dev_info *b_dev_info, > + struct list_head *pages); > +size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, > + struct list_head *pages, size_t n_req_pages); > > static inline void balloon_devinfo_init(struct balloon_dev_info *balloon) > { > -- > 2.52.0 >
